Skip to content

Use the published ephemeral rollups Pinocchio crate - #144

Merged
GabrielePicco merged 2 commits into
mainfrom
chore/pinocchio-0.11
Sep 20, 2026
Merged

GabrielePicco merged 2 commits into
mainfrom
chore/pinocchio-0.11

Conversation

@GabrielePicco

@GabrielePicco GabrielePicco commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

What

Replace the git-pinned ephemeral-rollups-pinocchio dependency with the published 0.16.2 crate.

The pinned revision only added the Magic ATA CPI used by this program. Encoding that CPI locally keeps the existing Pinocchio and test-runtime versions, so the broader Pinocchio 0.11 compatibility layer is unnecessary.

Changes

  • use ephemeral-rollups-pinocchio 0.16.2 from crates.io
  • preserve the same CreateMagicAta instruction data and account metadata locally
  • keep the existing Pinocchio 0.10 dependency graph

No behavior change is intended. The local CPI mirrors the helper from the previously pinned SDK revision.

Summary by CodeRabbit

  • Maintenance

    • Updated an underlying workspace dependency to a stable crates.io release.
  • Refactor

    • Improved the internal handling of Magic ATA destination creation while preserving existing behavior.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4189951d-9e00-4165-b679-e07364d6fee5

📥 Commits

Reviewing files that changed from the base of the PR and between 2788451 and 25b8caf.

📒 Files selected for processing (1)
  • e-token/src/processor/internal/magic_ata_destination.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4daea1ed-318d-4e13-869e-c811f6f3ef5a

📥 Commits

Reviewing files that changed from the base of the PR and between 7efe9b8 and 2788451.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • e-token/src/processor/internal/magic_ata_destination.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The PR updates ephemeral-rollups-pinocchio to crates.io version 0.16.2 and changes Magic ATA creation to use manually serialized instruction data with invoke_with_bounds.

Changes

Magic ATA dispatch

Layer / File(s) Summary
Pinocchio dependency update
Cargo.toml
The workspace dependency now uses crates.io version 0.16.2 instead of a Git revision.
Manual Magic ATA invocation
e-token/src/processor/internal/magic_ata_destination.rs
The code builds a 36-byte Magic Create ATA payload and dispatches it with invoke_with_bounds, using the magic program address as the program ID.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: dodecahedr0x

Merge Risk: ⚪ Minimal · up to 27884

No concrete current-head failure remains established for the updated Magic ATA dispatch.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary dependency change: replacing the Git-pinned ephemeral rollups Pinocchio crate with the published crates.io crate.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-19T13:03:38.705349Z 2788451 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Replace the git pin with ephemeral-rollups-pinocchio 0.16.2 from crates.io. Keep the existing Pinocchio runtime versions and inline the one Magic ATA CPI that is not part of that release.
@GabrielePicco GabrielePicco changed the title Move to the published SDK crates and pinocchio 0.11 Use the published ephemeral rollups Pinocchio crate Sep 19, 2026
@GabrielePicco
GabrielePicco merged commit 34da5dd into main Sep 20, 2026
4 checks passed
@GabrielePicco
GabrielePicco deleted the chore/pinocchio-0.11 branch September 20, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants