Integrate Fabled skill-API stat scaling and attribute sync#337
Open
Travja wants to merge 1 commit into
Open
Conversation
Travja
force-pushed
the
split/10-combat-formula-refactor
branch
from
July 23, 2026 05:26
eae315b to
b004641
Compare
Travja
force-pushed
the
split/11-fabled-hook-integration
branch
from
July 23, 2026 05:26
952d194 to
0d6c1b0
Compare
Travja
force-pushed
the
split/10-combat-formula-refactor
branch
from
July 23, 2026 05:38
b004641 to
2315fec
Compare
FabledHook now: - Syncs MAX_MANA (Divinity item stat) into Fabled's mana pool via PlayerMaxManaChangeEvent. - Pushes/clears Fabled PlayerAttributeModifiers derived from Divinity item attributes on equip change and player quit. - Exposes applyStatScale(player, statId, value), which lets Fabled's attributes.yml rescale any Divinity stat by name — wired into every EntityStats stat accessor (getDamageByType, getDefenseByType, getItemStat, getPenetration, getDynamicBuff) added across the preceding PRs in this stack. - Adds DivinityDamageEvent.Start/Dodge handlers that read a "fabled_dmg_flags" metadata bitmask off the damager to let Fabled skills suppress crit/skill-crit, force a block, zero bleed/vampirism, or force-cancel (dodge) on a specific hit. ItemAbilityHandler now clears a player's Fabled attribute modifiers on quit (previously only cleared on death).
Travja
force-pushed
the
split/11-fabled-hook-integration
branch
from
July 23, 2026 05:38
0d6c1b0 to
b211dcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #320 (piece 12/12 — stacked on #336, review #335 and #336 first).
FabledHooknow:MAX_MANA(Divinity item stat) into Fabled's mana pool viaPlayerMaxManaChangeEvent.PlayerAttributeModifiers derived from Divinity item attributes on equip change and player quit.applyStatScale(player, statId, value), which lets Fabled'sattributes.ymlrescale any Divinity stat by name — wired into everyEntityStatsstat accessor (getDamageByType,getDefenseByType,getItemStat,getPenetration,getDynamicBuff) added across Add damage/defense % buff and per-type penetration stats #335/Refactor combat defense formula, add per-type buffs/penetration to damage calc #336.DivinityDamageEvent.Start/Dodgehandlers that read afabled_dmg_flagsmetadata bitmask off the damager to let Fabled skills suppress crit/skill-crit, force a block, zero bleed/vampirism, or force-cancel (dodge) on a specific hit.ItemAbilityHandlernow clears a player's Fabled attribute modifiers on quit (previously only cleared on death).Generated by Claude Code