Allow specifying equipment slot for item attribute modifiers#334
Open
Travja wants to merge 1 commit into
Open
Conversation
The "attributes" section of an item config accepted "value:operation" (e.g. "2.0:ADD_NUMBER"). A third, optional segment now selects the Bukkit EquipmentSlot the modifier applies to (e.g. "2.0:ADD_NUMBER:HAND"), letting an attribute be scoped to a specific slot instead of applying everywhere. Note for reviewers: in applyItemMeta (ModuleItem.java, ~line 291), a slot-aware `mod` is constructed but never used — the loop still calls meta.addAttributeModifier(attribute.getKey(), attribute.getValue()), i.e. the original, non-slot-scoped modifier. As written, the new equipment-slot config option has no visible effect on generated items; the loop likely needs to pass `mod` instead of `attribute.getValue()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #320 (piece 9/12, independent).
The
attributessection of an item config acceptedvalue:operation(e.g.2.0:ADD_NUMBER). A third, optional segment now selects the BukkitEquipmentSlotthe modifier applies to (e.g.2.0:ADD_NUMBER:HAND), letting an attribute be scoped to a specific slot instead of applying everywhere.Note for reviewers: in
applyItemMeta(ModuleItem.java, ~line 291), a slot-awaremodis constructed but never used — the loop still callsmeta.addAttributeModifier(attribute.getKey(), attribute.getValue()), i.e. the original, non-slot-scoped modifier. As written, the new equipment-slot config option has no visible effect on generated items; the loop likely needs to passmodinstead ofattribute.getValue().Backward compatibility
Already fully backward compatible — the third
:SLOTsegment is optional (attrData.length > 2 ? attrData[2] : null), so every existing 2-segment attribute config parses exactly as before.