Add roman-numeral toggle for enchantment lore, hide-flags groundwork#333
Open
Travja wants to merge 1 commit into
Open
Add roman-numeral toggle for enchantment lore, hide-flags groundwork#333Travja wants to merge 1 commit into
Travja wants to merge 1 commit into
Conversation
lore.stats.style.enchantments.roman-system lets servers switch enchantment level display between roman numerals and plain arabic numbers (previously roman numerals were hardcoded below the max-roman threshold). Also adds attributes.hide-flags to engine.yml/EngineCfg, intended to toggle whether attributes/enchantments are hidden by default on custom items. Note for reviewers: this flag is only declared and loaded here — nothing in this change consumes it yet, so it's a no-op groundwork addition pending a follow-up that wires it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #320 (piece 8/12, independent).
lore.stats.style.enchantments.roman-systemlets servers switch enchantment level display between roman numerals and plain arabic numbers (previously roman numerals were hardcoded below themax-romanthreshold).Also adds
attributes.hide-flagstoengine.yml/EngineCfg, intended to toggle whether attributes/enchantments are hidden by default on custom items.Note for reviewers:
ATTRIBUTES_HIDE_FLAGSis only declared and loaded here — nothing in this change consumes it yet, so it's a no-op groundwork addition pending a follow-up that wires it up.Backward compatibility
Already safe by default —
roman-systemdefaults totrue, which is byte-for-byte the previous hardcoded behavior (roman numerals belowmax-roman). No migration needed.