Fix vanilla durability bar sync and block vanilla mending - #327
Open
Travja wants to merge 2 commits into
Open
Conversation
The vanilla durability bar was scaled incorrectly against custom durability, and vanilla mending bypassed the custom durability stat entirely. syncVanillaBar() now derives the displayed damage directly from the stat's own current/max percentage (with a safeguard so the bar never shows fully-repaired when custom durability isn't actually at max), and PlayerItemMendEvent is cancelled in favor of applying the repair through the custom durability stat.
Any addon compiled against the old 3-arg signature would fail to link after this change. Add it back as a @deprecated overload that delegates to the corrected single-arg version, so existing callers keep compiling/working (and get the fixed behavior) without needing to update immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #320 (piece 2/12, independent).
The vanilla durability bar was scaled incorrectly against custom durability, and vanilla mending bypassed the custom durability stat entirely.
syncVanillaBar()now derives the displayed damage directly from the stat's own current/max percentage (with a safeguard so the bar never shows fully-repaired when custom durability isn't actually at max), andPlayerItemMendEventis cancelled in favor of applying the repair through the custom durability stat.Backward compatibility
syncVanillaBarchanged from(item, current, maxCustom)to(item). Kept the old 3-arg signature as a@Deprecatedoverload that delegates to the corrected version, so any addon compiled against it keeps working (and gets the bugfix) without needing to update immediately.