This repository was archived by the owner on Nov 15, 2019. It is now read-only.
Null check before using get_class()#1
Open
romain-jacquart wants to merge 1 commit into
Open
Conversation
|
Hello @Anahkiasen this small fix makes your library compatible with PHP 7.2. |
Contributor
|
I'm sorry, the package is abandoned in favor of Spatie's. We indicated it on Packagist but not in the repository yet, we'll update the README to reflect this. |
|
This is totally fine to want to stop maintaining a package and thank you for pointing to an alternative, unfortunately it is not compatible with PHP 5.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of PHP 7.2,
get_class()parameter can not be null.This PR adds a simple null check before using
get_class().