Skip to content

Add 2 claimant proposals#24

Open
toninorair wants to merge 2 commits into
mainfrom
feat/add-proposals-epoch-12
Open

Add 2 claimant proposals#24
toninorair wants to merge 2 commits into
mainfrom
feat/add-proposals-epoch-12

Conversation

@toninorair

@toninorair toninorair commented Oct 9, 2024

Copy link
Copy Markdown
Collaborator

Claimants proposals for current epoch

@toninorair toninorair marked this pull request as ready for review October 10, 2024 15:47
Comment thread foundry.toml
Comment on lines -18 to -20
block_number = 19_818_700
block_timestamp = 1_715_091_047
fork_block_number = 19_818_700

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be kept to not break the integration tests.

@deluca-mike deluca-mike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the script is correct, we should get into the habit of creating cleaner, more standardized, and more testable scripts, with accompanying tests, in this case, for the proposal creations and for the resulting key-velue sets having the desired effects at the Wrapper.

@toninorair

Copy link
Copy Markdown
Collaborator Author

While the script is correct, we should get into the habit of creating cleaner, more standardized, and more testable scripts, with accompanying tests, in this case, for the proposal creations and for the resulting key-velue sets having the desired effects at the Wrapper.

@deluca-mike that is something I would like to propose you do every voting epoch given that it is directly related to the wrapper project. All great and necessary points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants