This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Remove unused dependencies: greenlet, cffi#403
Open
gdrosos wants to merge 2 commits intolyft:masterfrom
Open
Conversation
Author
|
Hello @ramonpetgrave64, @skiptomyliu, @alejandroroiz I hope this message finds you well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as a maintainer would greatly contribute to our research efforts. Could you please take a moment to review these changes? Your input would be highly valuable to us. Thank you for your consideration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the removal of the unused dependencies
greenletandcffifrom the project. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects.Rationale
The
greenletdependency was added in 180a65e but remains unused, serving only as a transitive dependency. Similarly, thecffidependency, added in 2208815, is no longer required due to updates in thecryptographydependencies.Removing these unused dependencies contributes to a leaner codebase, reduces security risks, and simplifies dependency management.
Changes
greenletandcffidependencies fromrequirements.in.requirements3.txtto reflect the removed dependencies.Impact
I also signed the Contributor License Agreement (CLA) according to the contributing guidelines