This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Add access control to credentials based on group membership#293
Open
GarretReece wants to merge 9 commits intolyft:masterfrom
Open
Add access control to credentials based on group membership#293GarretReece wants to merge 9 commits intolyft:masterfrom
GarretReece wants to merge 9 commits intolyft:masterfrom
Conversation
adds group field to form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a groups field to credentials. If a user is not in one of the groups associated with a credential then they will be unable to interact with the credential.
This PR picks up from the work in PR #289, updated to the current structure for Confidant, and adds multi group support.