Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
工单 LUM-202611-b87f6fc5 的
Cannot read properties of undefined (reading 'x')来自 OrbitControls:尚未结束的鼠标拖动和新触摸被计为两根手指,但鼠标没有触摸坐标,移动时进入双指缩放后报错。为锁定的 three-stdlib 2.36.1 加入 pnpm 补丁,统一 ESM/CommonJS 手势状态管理:同一手势只接受同类输入,忽略重复与未登记触点,捕获释放事件,销毁时清空触点;双指结束后剩余手指可继续旋转。保留现有 Drei、相机行为和滚轮缩放适配。
Validation
segmented_86214e3c_d74a304b3a07.glb在 Chrome 验证:原版重现与工单相同的handleTouchMoveDolly堆栈;补丁应用后,同样的鼠标按下→触摸移动序列不再报错,正常双指缩放和单指接续旋转均有效。python scripts/run_vitest.py run src/utils/__tests__/orbitPointerLifecycle.test.ts src/utils/__tests__/wheelZoom.test.ts:通过。python scripts/run_smoke_tests.py、git diff --check:通过。原始模型和浏览器验证材料仅在本地保留。
AI assistance
Models and tools: GPT-6 系列,具体变体未提供(via Codex)。
What each model helped with: 对照工单堆栈、复现混合输入、修复控件触点生命周期、编写真实依赖回归、验证原模型交互与补丁安装并撰写说明。
How the output was checked: Codex 实际运行 Validation 中的测试、构建、安装和浏览器输入,核对原版失败及修复后的相机变化和错误日志。