fix(codex): 隔离 Codex Desktop 完成通知#281
Merged
Merged
Conversation
技术变更: - 在通知生成脚本中校验 CODEXFLOW_NOTIFY_TAB_ID,缺失或仅含空白时不写入完成事件。 - 生命周期 hook 在无有效标签页标记时返回 continue/suppressOutput,避免影响 Codex Desktop。 - 通知读取端在历史刷新和渲染进程分发前过滤无标签页标记的事件。 - 补充无标记与空白标记的回归测试,覆盖 lifecycle hook、Shell 和通知分发。 产品行为: - Codex Desktop 与 CodexFlow 共用全局 Codex 配置时,Desktop 的完成事件不再误触发 CodexFlow 通知或历史刷新。 - 由 CodexFlow 启动且携带有效标签页标记的 Codex 会话仍按原有链路发送完成通知。 测试: - npm run test(205 个测试文件、1,281 项测试通过) - npm run i18n:check - npm run build:electron Signed-off-by: Lulu <58587930+lulu-sk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
技术变更:
产品行为:
测试: