support synchronous put operation#15
Closed
davidAtInleague wants to merge 3 commits into
Closed
Conversation
requires that cf code pass a `{...,synchronous:true}` param in
its config to the plugin
Contributor
Author
|
closed in favor of #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #13, this enables a "synchronous" mode for the put operation. A configuration can now look like:
Very high confidence this fixes the reported race condition, but I haven't done any performance regression testing to see how this pans out in the real world. However, the new option is entirely opt-in, so any regressions would be new behavior that people have to sign up for via configuration.