feat: launch named agents from config#73
Merged
Merged
Conversation
Add a small TOML agent config (mirrors Zed's agent_servers): each [agents.<name>] has command / args / optional env. Resolve and launch by name with `--agent <name>` on both binaries (acp-mux and rooms); `--config <path>` overrides the default location ($XDG_CONFIG_HOME/acp-mux/agents.toml or ~/.config/acp-mux/agents.toml), and `--list-agents` prints the configured set. - New core module `acp_mux::agent_config` (load + resolve + list), with the resolution logic shared by both binaries. - `--agent` and the raw `--agent-cmd` escape hatch are mutually exclusive; unknown agent names error with the known set listed. - Per-agent `env` support: `AgentCmd` carries env and `AgentProcess::spawn` applies it on top of the inherited process environment. - Unit tests for parsing, env conversion, resolution precedence, mutual exclusion, and unknown-name errors.
Add a "Named Agents" section to the README, a copyable docs/examples/agents.toml, and a CHANGELOG entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acp-mux/roomsvia--agent,--config, and--list-agentsagents.tomlshape and add a copyable example configVerification
git diff --check origin/main --cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test