fix: return queue-not-found for missing queue items#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-32004JSON-RPC error for missingamux/unqueue_promptqueue items.queueItemIdparams on-32602, so clients can distinguish invalid input from queue remove/submit races.Scope
queueItemIderror semantics foramux/unqueue_prompt.Tests
cargo test amux_unqueue_prompt_missing_item_uses_queue_not_found_error -- --nocapturefailed with-32602before the implementation.cargo test amux_unqueue_prompt_missing_item_uses_queue_not_found_error -- --nocapturecargo fmt --checkgit diff --checkcargo testcargo clippy --all-targets -- -D warningsPart of #43.