Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s Markdown linting from markdownlint to the Python-based rumdl, aligning local (make lint) and CI lint behavior via uv, and cleans up related configuration/docs.
Changes:
- Add
rumdlas a dev dependency and configure it viapyproject.toml(disable MD013/MD041, set MD004 style). - Replace the
markdownlintMakefile/CI workflow implementation withuv run rumdl check ., and remove obsolete.markdownlint*configs. - Minor Markdown/doc formatting adjustments (PR template list markers; small doc spacing fixes).
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds locked rumdl dependency artifacts. |
pyproject.toml |
Adds rumdl to dev deps and introduces [tool.rumdl] configuration. |
Makefile |
Switches lint target to uv run rumdl check .. |
doc/configuration_merge_guide.md |
Minor whitespace/formatting tweak. |
.markdownlintignore |
Removed (no longer needed). |
.markdownlint.yaml |
Removed (no longer needed). |
.github/workflows/markdown.yaml |
Replaces markdownlint action with uv + rumdl invocation. |
.github/PULL_REQUEST_TEMPLATE.md |
Switches checklist markers to - [ ] (dash style). |
.github/CONTRIBUTING.md |
Minor formatting (blank lines). |
Comments suppressed due to low confidence (1)
.github/CONTRIBUTING.md:104
make checknow runsmake lint, which runsrumdl. The contributing doc’s checklist currently only mentions ruff under "Linting", which can be confusing when contributors hit a markdown-lint failure. Consider updating this bullet to mention rumdl/markdown linting as part of the required checks.
- ✅ **Tests**: All pytest tests must pass
- ✅ **Type checking**: No mypy errors
- ✅ **Linting**: Code must pass ruff checks
- ✅ **Formatting**: Follow existing code style
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the previous markdown linting setup with the new
rumdllinter, updates related configuration files, and makes minor improvements to the contributing and pull request documentation. The changes streamline markdown linting across the project and ensure that the configuration is consistent and up-to-date.