fix(cmd): add stop subcommand to check preflight, trim volume, and get replica - #583
Open
kiusys-mstreitenberger wants to merge 1 commit into
Open
Conversation
…t replica Mirrors the existing install preflight stop / export replica stop pattern. If one of these commands is interrupted before its PostRun cleanup runs, the DaemonSet (and RBAC, for check preflight) it created is left behind in the cluster. stop lets the user clean those up manually. checksum is intentionally left out: its Cleanup() is a no-op since it only patches the Volume CR directly and creates no cluster resources that could be orphaned. Issue longhorn/longhorn#9311 Signed-off-by: Nicolás Streitenberger <mnstreitenberger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9311
What this PR does / why we need it:
A
stopcommand has been added tocheck preflight,trim volume, andget replica.checksumwas deliberately excluded: itsCleanup()is a no-op, as it merelyupdates the Volume CR directly and does not create any cluster resources that
could become orphaned.
Special notes for your reviewer:
stopcommand follows the exact pattern ofexport replica stop.stopstopcommand removes them.Additional documentation or context