Repository navigation
Bump gpui-pre to 0.3.6 - #18
Merged
Merged
Conversation
yuanzhuang-svg
force-pushed
the
bump-gpui-pre-0.3.6
branch
2 times, most recently
from
September 22, 2026 11:48
5052cc2 to
d790aed
Compare
gpui-pre 0.3.6 changed `PlatformAtlas::get_or_insert_with` to take the `AtlasKey` by value (was `&AtlasKey`). Adapt both the iOS and Android `FallbackAtlas` impls accordingly, and bump the pinned `gpui-pre` / `gpui-pre-wgpu` / `gpui-pre-reqwest-client` deps (lib + example) from =0.3.5 to =0.3.6. The example's pinned `gpui-kit` rev is moved from 9504b46 to 13c716b6 to match gpui-pre 0.3.6 (the old rev's inspector API expects a different `register_inspector_element` closure arity). Without this, downstreams that pull gpui-kit 0.6.5 (which requires gpui-pre =0.3.6) cannot resolve alongside gpui-mobile (pinned =0.3.5) — e.g. the ai-chat iOS example no longer builds after it moved panel to gpui-kit's `Message`/`Marker` APIs. Verified: `cargo check --target aarch64-apple-ios-sim` is clean for both the lib and the example. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yuanzhuang-svg
force-pushed
the
bump-gpui-pre-0.3.6
branch
from
September 22, 2026 11:57
d790aed to
1e194e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FallbackAtlasimpl to gpui-pre 0.3.6, which changedPlatformAtlas::get_or_insert_withto takeAtlasKeyby value (was&AtlasKey).gpui-pre/gpui-pre-wgpu/gpui-pre-reqwest-clientdeps(lib + example) from
=0.3.5to=0.3.6.Why
gpui-kit 0.6.5 requires
gpui-pre =0.3.6, but gpui-mobile pins=0.3.5— the twoexact pins are irreconcilable. Any downstream on gpui-kit 0.6.5 can't resolve
alongside gpui-mobile. Concretely, the ai-chat iOS example stopped building
after panel moved to gpui-kit's
Message/MarkerAPIs (ai-chat #73, #82): the iOSworkspace is stuck on gpui-kit 0.6.2 because gpui-mobile only allows gpui-pre 0.3.5.
Verified
cargo check --lib --target aarch64-apple-ios-simis clean after the change.🤖 Generated with Claude Code