Repository navigation
Conversation
run_app builds the Application with the unit asset source, so every kit Icon paints a blank slot, and there is no post-run setter. set_app_assets registers an Arc<dyn gpui::AssetSource> before run_app and the runner installs it via with_assets, keeping the runner decoupled from any bundle the app might choose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_appconstructs theApplicationwith the unit asset source, so any consumer that ships its own assets (kitIcons, for example) paints blank slots — and there is no post-run setter, because the runner owns Application construction.This adds a seam:
set_app_assets(Arc<dyn gpui::AssetSource>)registers a source beforerun_app, and the runner installs it viawith_assets. It keeps the runner decoupled from any particular bundle — the app passes its owninclude_bytes!bundle from its registration callback.We use this in an iOS app host; without it every kit icon is blank. Android does not need it (the app owns
android_mainand chainswith_assetsitself), so this is the iOS-side twin.