Repository navigation
Conversation
A release tag cannot be changed after publishing, so its website content can only be corrected by cutting a new release. v0.7.0 was tagged before #3284 made the docs follow the Kit version, and the site still shows 0.6. When `origin/website/<tag>` exists, snapshot the docs and homepage from it instead of the tag; versions still resolve from the tag. Include the content commit in the historical build cache key so an updated branch is rebuilt. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
Not merging: the script change is only needed once to republish v0.7.0. Release Website is run from this branch via workflow_dispatch instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v0.7.0 website still shows
gpui-kit = "0.6". The cause is the content, not the build cache: the latest release is rebuilt on every run from the tag's docs and homepage, and v0.7.0 was tagged before #3284 replaced the hardcoded versions with{{gpui_kit_version}}. A published tag should not move, and correcting its docs should not require a new release.script/build-website-versionsnow fetcheswebsite/*branches. Whenorigin/website/<tag>exists, the docs andHomeApp.vueare snapshotted from it instead of the tag.GPUI_KIT_VERSIONandGPUI_PRE_VERSIONstill resolve from the tag. The historical build cache key now includes the content commit, so an updated branch is rebuilt instead of served from cache.The
website/v0.7.0branch is already pushed. It is cut fromv0.7.0and carries only the content part of adde487 (#3284): 19 docs files plusHomeApp.vue, identical line-for-line to that commit, with no other commits.After merging, manually run Release Website from
main. The automaticworkflow_runtrigger checks out the tag commit and would use the old script.How to Test
bash -n script/build-website-versionspassed.script/snapshot-website . website/v0.7.0 <dir>: the snapshot has nogpui-kit = "0.6"; docs use{{gpui_kit_version}}andHomeApp.vueusesprops.kitVersion.Checklist
🤖 Generated with Claude Code