-
Notifications
You must be signed in to change notification settings - Fork 1
Bump @prisma/client from 6.19.1 to 7.2.0 #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note
|
| Cohort / File(s) | Change Summary |
|---|---|
Dependency Version Update packages/app/prisma-utils/package.json |
Updated @prisma/client devDependency from ~6.19.0 to ~7.2.0 |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
- Verify that the version constraint in peerDependencies (>=5.0.0 <7.0.0) is intentional given the bump to ~7.2.0, or confirm if it requires adjustment
- Confirm compatibility with other dependencies in the workspace
Suggested reviewers
- kibertoad
- CarlosGamero
- dariacm
- github-actions
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The PR description lacks required sections: no 'Changes' section describing the update, no release/version label (though 'major' and 'skip-release' labels are applied), and no documentation or test update checklist items. | Add a 'Changes' section briefly describing the @prisma/client update, and complete the checklist items indicating whether documentation and tests were updated or if changes were unnecessary. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately describes the main change: updating @prisma/client from 6.19.1 to 7.2.0, which is the sole modification in the changeset. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
dependabot/npm_and_yarn/prisma/client-7.2.0
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (2)
- UTF-8: Request failed with status code 404
- TML-1670: Request failed with status code 404
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/app/prisma-utils/package.json (1)
42-45: Critical: peerDependencies constraint blocks @prisma/client v7.The peerDependencies constraint
"<7.0.0"conflicts with the devDependency upgrade to 7.2.0 (line 52). This creates a critical mismatch:
- The package declares it requires @prisma/client <7.0.0
- But it's being developed and tested against 7.2.0
- Consumers installing this package with @prisma/client 6.x may encounter compatibility issues that weren't caught during testing
🔎 Proposed fix to update peerDependencies
"peerDependencies": { - "@prisma/client": ">=5.0.0 <7.0.0", - "prisma": ">=5.0.0 <7.0.0" + "@prisma/client": ">=5.0.0 <8.0.0", + "prisma": ">=5.0.0 <8.0.0" },
📜 Review details
Configuration used: Repository: lokalise/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/app/prisma-utils/package.json
| "@lokalise/fastify-extras": "^30.2.1", | ||
| "@lokalise/tsconfig": "^1.3.0", | ||
| "@prisma/client": "~6.19.0", | ||
| "@prisma/client": "~7.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat packages/app/prisma-utils/package.json | head -60Repository: lokalise/shared-ts-libs
Length of output: 2214
Update peerDependencies to allow @prisma/client v7.
The peerDependencies constraint @prisma/client: >=5.0.0 <7.0.0 conflicts with the devDependency ~7.2.0. The tilde operator expands to >=7.2.0, <8.0.0, which cannot satisfy the upper bound of <7.0.0. Update peerDependencies to include v7 (e.g., >=5.0.0 <8.0.0 or more specifically >=5.0.0 <9.0.0 if following Prisma's SemVer approach).
🤖 Prompt for AI Agents
In packages/app/prisma-utils/package.json around line 52, the peerDependencies
range for @prisma/client (currently >=5.0.0 <7.0.0) conflicts with the
devDependency "~7.2.0"; update the peerDependencies to allow v7 (for example
change the range to >=5.0.0 <8.0.0 or >=5.0.0 <9.0.0 depending on desired future
compatibility) so the peer constraint includes the devDependency version and
keep semver consistency between peerDependencies and devDependencies.
| "@prisma/client": "~7.2.0", | ||
| "@vitest/coverage-v8": "^3.2.4", | ||
| "cross-env": "^10.0.0", | ||
| "prisma": "~6.19.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major: Prisma CLI version mismatch with @prisma/client.
The prisma CLI remains at 6.19.0 while @prisma/client has been upgraded to 7.2.0 (line 52). These packages should be kept in sync to avoid schema generation, migration, and compatibility issues.
🔎 Proposed fix to sync prisma CLI version
- "prisma": "~6.19.0",
+ "prisma": "~7.2.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "prisma": "~6.19.0", | |
| "prisma": "~7.2.0", |
🤖 Prompt for AI Agents
In packages/app/prisma-utils/package.json around line 55, the project has a
Prisma CLI version ("prisma": "~6.19.0") that does not match the upgraded
@prisma/client (7.2.0) and can cause generation/migration incompatibilities;
update the prisma CLI dependency to the matching 7.2.0 (or a compatible semver
range like "~7.2.0" or "^7.2.0") so both @prisma/client and prisma are the same
major/minor version and then run npm/yarn install and regenerate the client.
4b7dad6 to
3d78914
Compare
Bumps [@prisma/client](https://github.com/prisma/prisma/tree/HEAD/packages/client) from 6.19.1 to 7.2.0. - [Release notes](https://github.com/prisma/prisma/releases) - [Commits](https://github.com/prisma/prisma/commits/7.2.0/packages/client) --- updated-dependencies: - dependency-name: "@prisma/client" dependency-version: 7.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
3d78914 to
6b6e44e
Compare
Bumps @prisma/client from 6.19.1 to 7.2.0.
Release notes
Sourced from
@prisma/client's releases.... (truncated)
Commits
bebccbdfeat(cli): customizeprisma initbased on the JS runtime (Bun vs other) (#2...09b4a1dfix(cli): makeprisma version --jsonemit JSON only to stdout (#28911)ed03287feat(config): allow undefined urls in e.g.prisma generate(#28895)531886ffix: fix byte upserts by removing legacy byte array representation (#28913)db5fad9chore(deps): update engines to 7.2.0-4.0c8ef2ce45c83248ab3df073180d5eda9e8be7...040fc8ffix(client): fix tracing tests failing with QPE (#28886)6b8702cfix(client,internals,migrate,generator-helper): handle multibyte UTF-8 charac...549a8dcchore(deps): update engines to 7.2.0-2.e042035cb3c6e24bbedc3e886c89675fbd6145...0c6db15fix(adapter-{pg,neon,ppg}): handle 22P02 error in Postgres (#28849)857400bfix(client-engine-runtime): makeDataMapperErroraUserFacingError(#28846)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.