Degrade gracefully when data-of-loathing is unavailable#322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-of-loathingto 4.3.1, which falls back to a cached local SQLite database when the remote server is unreachable (previously would throw immediately on any network error)DataOfLoathingClient.load()in a try/catch so a total load failure (first boot, no cache, server down) no longer crashes the bot — it starts in degraded mode with empty maps, which existing callers already handle gracefully via null checkslastDownloadTimeis now updated unconditionally so a failed reload doesn't trigger a retry on every subsequent requestdiscordClient.alert()if the bot starts in degraded modeTests
DataOfLoathingClient: load doesn't throw on failure,loadedflag reflects success/failure,reload()doesn't retry within an hour after a failurePizzaTree: returns empty results when built with no data (degraded mode), correctly indexes hookah-eligible effects and excludes avatar effects,precalculatesets the right pizza metadata