Skip Assert your Authority on insta-kill-immune monsters - #2686
Open
eegeeZA wants to merge 1 commit into
Open
Conversation
KoL's semirare system can preempt a garbo-forced wander with an unrelated monster, regardless of what garbo intended to fight. If that monster is BOSS/LUCKY/ULTRARARE-flagged, Assert your Authority still consumes one of its 3 daily casts even though the insta-kill fails against it. Guard the skill with a fight-time monsterid allowlist built from availableMonsters() (the zone's native monsters, already excluding those attributes) instead of the intended wander target alone. The guard has to be a KoL macro-language condition rather than a JS check: GarboStrategy submits this macro as an autoattack, which grimoire compiles before the actual monster is revealed. availableMonsters() previously wasn't exported from the garbo-lib package entry point; add it to the re-export list so garbo can use it. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
There's no such thing as semirares anymore. Why were you lucky! in the zeppelin? |
Contributor
Author
I think I misdiagnosed the 'semi-rare' part, but I still think this could protect against: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assert your Authority is capped at 3 uses/day.
— if that monster is
BOSS/LUCKY/ULTRARAREflagged, the cast still burns a daily charge even though the insta-kill
fails against it. Observed live: garbo expected "man with the red buttons"
but a
Ron "The Weasel" Copperhead(BOSS-flagged) preempted thewander, and the skill was cast at it anyway.
monsteridallowlist built fromavailableMonsters(location)— the zone's native monsters, alreadyexcluding
LUCKY/ULTRARARE/BOSS. This has to be a KoL macro-languagecondition rather than a JS-side check:
GarboStrategysubmits this macroas an autoattack, which grimoire's engine compiles before the actual
monster is revealed.
availableMonsterspreviously wasn't exported from thegarbo-libpackage entry point (only from
wanderer/lib.tsinternally); added it tothe re-export list.
Scope note
Cheese Wizard Fondeluge,Spit Acid, andPig Skinner Free-For-Allin thesame file share the same unconditional
.skill()cast shape and plausiblythe same gap, but they're not daily-capped resources in the same way and
were left out of scope here — worth a follow-up if it's a live problem for
them too.
Test plan
packages/garbohas no automated test suite; verified via:yarn check(tsc across workspaces) — passesyarn lint(eslint + prettier) — passesyarn build— passes; confirmed the guard logic andavailableMonstersare present in the compiled
garbo.jsoutputNo way to exercise KoL's live preemption from CI — the fix's
runtime effect isn't test-covered.
Assisted by Claude Code — reviewed by @eegeeZA; verified by the test suite.