feat: remote listener for multiple device setup #198
+127
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for displaying invoices across devices. Useful for a 2 device merchant setup.
motorina0
reviewed
Feb 9, 2026
| const url = new URL(window.location) | ||
| url.protocol = url.protocol === 'https:' ? 'wss' : 'ws' | ||
| url.pathname = `/api/v1/ws/${this.tposId}` | ||
| const ws = new WebSocket(url) |
Collaborator
There was a problem hiding this comment.
@dni this is a common patter. Maybe we need an JS utils like wsFromPath()
Collaborator
There was a problem hiding this comment.
I'll add to my TODO!
Member
There was a problem hiding this comment.
there is.
const websocketPrefix =
window.location.protocol === 'http:' ? 'ws://' : 'wss://'
const websocketUrl = `${websocketPrefix}${window.location.host}/api/v1/ws`so one could use those instead.
dni
reviewed
Feb 11, 2026
| const url = new URL(window.location) | ||
| url.protocol = url.protocol === 'https:' ? 'wss' : 'ws' | ||
| url.pathname = `/api/v1/ws/${this.tposId}` | ||
| const ws = new WebSocket(url) |
Member
There was a problem hiding this comment.
Suggested change
| const ws = new WebSocket(url) | |
| const ws = new WebSocket(`${websocketUrl}/${this.tposId}`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for merchants creating the order on one device and getting payments on another.