Skip to content

Should base-clocks/models/priors be abstract? #255

Description

@Anaphory

BaseClock doesn't have a branch rate model, which to me makes that method pretty abstract, so the whole class is? It also lacks __type__ and __distribution__, and declaring it abstract would prevent an accidental instantiation if after some refactoring [clock] type=base would theoretically run etc.

Originally posted by @Anaphory in #248

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions