doc: clarify auth webhook maxPrice scope - #4019
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4019 +/- ##
===================================================
- Coverage 35.52297% 35.52076% -0.00221%
===================================================
Files 174 174
Lines 45213 45213
===================================================
- Hits 16061 16060 -1
- Misses 27878 27879 +1
Partials 1274 1274 see 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
The auth webhook maxPrice is checked only when the webhook fires and is not retained across cached auth requests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rickstaa
force-pushed
the
docs/remote-signer-auth-webhook-maxprice-scope
branch
from
August 12, 2026 08:25
02bfc93 to
e0a2633
Compare
j0sh
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion in #4014.
The auth webhook
maxPriceand the authexpirycaching are each documented, but their interaction is not. The webhookmaxPriceis checked only inside thecallbackResp != nilbranch (server/remote_signer.go:681-694), so it is not evaluated while auth is cached, and it is not stored inRemotePaymentState, so it does not carry over to later requests. The other ceilings (configured max, requestmaxPrice, initial session price) do run on every request atserver/remote_signer.go:586-590.Adds one sentence to the pricing-checks section pointing at the expiry caching docs.
Docs only, no behavior change.