Update for BC R128#813
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not properly tested; as usual, bumped bc-stubs, then whacked everything back into shape so TS stayed down.
The first 3 commits are just that. The last commit (if I didn't mess up) is where stuff gets a bit shoddy, since I lack the knowledge about the inner workings of LSCG; but it's the one point where I adapt the code to the removal of all of the transient properties (the ones that were only there so the
AssetAddprocess could inherit values around), likeOpacityandDrawingTop/Left.It does mean that, if what I (shoddily) implemented isn't enough, you'll have to go look back at the raw definitions in
AssetFemale3DCGto grab the values out of there (I'm looking at that drawing coordinate reset, for example).The other issue is that, while https://gitgud.io/BondageProjects/Bondage-College/-/merge_requests/6337 is not merged, there's not much you can do here, since I papered over your papering over by putting back all of the real assets in. Sorry about that, I should have checked what you were up to before doing a hotfix for that 😬.
Anyway, looking at what you're doing in there, and given that whole "shadow assets" doesn't quite vibe with me, I have a hunch it might be possible to get the same results by patching into
CharacterAppearanceVisible? WCE already does that for its own hide overriding, so you wouldn't be alone 😅.