fix: cross-platform socket handling for Windows#807
Closed
kajukitli wants to merge 2 commits into
Closed
Conversation
- Replace libc socket types with socket2::SockAddr for cross-platform compatibility - Use #[cfg(unix)] for fcntl calls (non-blocking on Windows handled by libuv) - Add Windows-specific ioctlsocket for non-blocking mode - Update libnghttp2 dependency to use fixed enum constants
- Wrap libc::fcntl calls in #[cfg(unix)] block - Use ioctlsocket on Windows for non-blocking mode - Replace libc socket types with socket2::SockAddr for cross-platform compat - Update libnghttp2 to fix bindgen enum type consistency (i32 vs u32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Windows build failures by:
libcsocket types (sockaddr_storage,sockaddr_in,sockaddr_in6, etc.) with cross-platformsocket2::SockAddrfcntlcalls with#[cfg(unix)]ioctlsocketfor non-blocking modeThis fixes the Windows CI failures in denoland#32418.