Interface with ducc0 noise generation and documentation improvements #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an interface with the
ducc0noise generation module, offering a significant performance boost for long timelines. It refactors thenoise.pymodule to support multiple noise generation engines and physical models, while improving documentation and defaulting to the standard FFT-based approach for backward compatibility.Key Changes
New Noise Engines & Models:
engine="ducc", which usesducc0.misc.OofaNoisefor time-domain filtering. This is faster and more memory-efficient for long simulations.model="keshner"(native to DUCC) alongside the existingmodel="toast", which implements the model in toast.add_one_over_f_noiseto dispatch betweenfft(default) andduccengines.API Updates:
add_noise_to_observationsand underlying functions now acceptengineandmodelarguments.engine="fft"andmodel="toast"to ensure backward compatibility.ValueErrorifengine="ducc"is used withmodel="toast").