Skip to content

[Next] util.js splitByGlyph: Use new JS native method #13347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fredcw wants to merge 1 commit into from
+4 −14
Closed

[Next] util.js splitByGlyph: Use new JS native method #13347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions js/misc/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,24 +716,14 @@ function getDesktopActionIcon(action) {
* @str (string): The string to be converted
*
* Converts a string, possibly containing multiple codepoint unicode characters (e.g. emoji), into
* an array of unicode graphemes clusters (glyphs). For example: "👩‍👩‍👧‍👧😃".length === 13, but splitByGlyph("👩‍👩‍👧‍👧😃")
* an array of unicode graphemes or grapheme clusters. For example: "👩‍👩‍👧‍👧😃".length === 13, but splitByGlyph("👩‍👩‍👧‍👧😃")
* returns ["👩‍👩‍👧‍👧", "😃"] which is length 2.
*
* Returns (array): Array of unicode grapheme clusters (glyphs).
* Returns (array): Array of unicode graphemes or grapheme clusters.
*/
function splitByGlyph(str) {
const glyphs = [];
const buffer = new Gtk.TextBuffer();
buffer.set_text(str, -1);
const iter = buffer.get_start_iter();
const iter2 = buffer.get_start_iter();

while (!iter2.is_end()) {
iter2.forward_cursor_position();
glyphs.push(buffer.get_text(iter, iter2, false));
iter.forward_cursor_position();
}
return glyphs;
const segmenter = new Intl.Segmenter(undefined, { granularity: 'grapheme' });
return Array.from(segmenter.segment(str), (s) => s.segment);
}

function wiggle(actor, params) {
Expand Down
Loading