Skip to content

Fix: avoid assigning to read-only config_entry in OptionsFlow (fixes options UI 500 error) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jelofsson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: avoid assigning to read-only config_entry in OptionsFlow (fixes options UI 500 error) #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions custom_components/greenely/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,12 @@ class ConfigFlow(ConfigFlow, domain=DOMAIN):
@staticmethod
@callback
def async_get_options_flow(
config_entry: ConfigFlow,
config_entry: ConfigEntry,
) -> GreenelyOptionsFlow:
"""Create the options flow."""
return GreenelyOptionsFlow(config_entry)


async def async_step_user(
self, user_input: dict[str, Any] | None = None
) -> ConfigFlowResult:
Expand Down Expand Up @@ -128,7 +129,8 @@ class GreenelyOptionsFlow(OptionsFlow):

def __init__(self, config_entry: ConfigEntry) -> None:
"""Initialize Greenely options flow."""
self.config_entry = config_entry
self._config_entry = config_entry


async def async_step_init(
self, user_input: dict[str, Any] | None = None
Expand All @@ -146,62 +148,63 @@ def _get_options_schema(self):
{
vol.Optional(
GREENELY_PRICES,
default=self.config_entry.options.get(GREENELY_PRICES, True),
default=self._config_entry.options.get(GREENELY_PRICES, True),
): bool,
vol.Optional(
GREENELY_DAILY_USAGE,
default=self.config_entry.options.get(GREENELY_DAILY_USAGE, True),
default=self._config_entry.options.get(GREENELY_DAILY_USAGE, True),
): bool,
vol.Optional(
GREENELY_HOURLY_USAGE,
default=self.config_entry.options.get(GREENELY_HOURLY_USAGE, False),
default=self._config_entry.options.get(GREENELY_HOURLY_USAGE, False),
): bool,
vol.Optional(
GREENELY_DAILY_PRODUCED_ELECTRICITY,
default=self.config_entry.options.get(
default=self._config_entry.options.get(
GREENELY_DAILY_PRODUCED_ELECTRICITY, False
),
): bool,
vol.Optional(
GREENELY_USAGE_DAYS,
default=self.config_entry.options.get(GREENELY_USAGE_DAYS, 10),
default=self._config_entry.options.get(GREENELY_USAGE_DAYS, 10),
): int,
vol.Optional(
GREENELY_PRODUCED_ELECTRICITY_DAYS,
default=self.config_entry.options.get(
default=self._config_entry.options.get(
GREENELY_PRODUCED_ELECTRICITY_DAYS, 10
),
): int,
vol.Optional(
GREENELY_DATE_FORMAT,
default=self.config_entry.options.get(
default=self._config_entry.options.get(
GREENELY_DATE_FORMAT, "%b %d %Y"
),
): str,
vol.Optional(
GREENELY_TIME_FORMAT,
default=self.config_entry.options.get(
default=self._config_entry.options.get(
GREENELY_TIME_FORMAT, "%H:%M"
),
): str,
vol.Optional(
GREENELY_HOURLY_OFFSET_DAYS,
default=self.config_entry.options.get(
default=self._config_entry.options.get(
GREENELY_HOURLY_OFFSET_DAYS, 1
),
): int,
vol.Optional(
GREENELY_FACILITY_ID,
default=self.config_entry.options.get(GREENELY_FACILITY_ID),
default=self._config_entry.options.get(GREENELY_FACILITY_ID),
): int,
vol.Optional(
GREENELY_HOMEKIT_COMPATIBLE,
default=self.config_entry.options.get(
default=self._config_entry.options.get(
GREENELY_HOMEKIT_COMPATIBLE, False
),
): bool,
}
)


class InvalidAuth(HomeAssistantError):
"""Error to indicate there is invalid auth."""