Skip to content

add replication throttle config to rebalance/add/remove/demote options#129

Open
countableSet wants to merge 2 commits into
linkedin:masterfrom
countableSet:replication-throttle
Open

add replication throttle config to rebalance/add/remove/demote options#129
countableSet wants to merge 2 commits into
linkedin:masterfrom
countableSet:replication-throttle

Conversation

@countableSet

@countableSet countableSet commented Jan 21, 2025

Copy link
Copy Markdown

adds replication throttle configuration to configuration options for rebalance, add, remove, and demote broker

plus move around ui for demote to fit the new input box better
fix bug with demote broker where concurrent_leader_movements wasn't being set

cc #126

Screenshot 2025-01-21 at 11 44 15 Screenshot 2025-01-22 at 13 45 41

other fixes

  • dev server wouldn't start without adding require path (node version v18.16.1)
❯ npm run dev

> cruise-control-ui@0.3.0 dev
> test -d cruise-control-ui && cd cruise-control-ui; node build/dev-server.js

/Users/countableset/code/countableset/cruise-control-ui/build/webpack.dev.conf.js:33
      favicon: path.resolve(__dirname, '../src/assets/images/cc-favicon.png'),
               ^

ReferenceError: path is not defined
    at Object.<anonymous> (/Users/countableset/code/countableset/cruise-control-ui/build/webpack.dev.conf.js:33:16)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Users/countableset/code/countableset/cruise-control-ui/build/dev-server.js:15:21)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Node.js v18.16.1
  • localhost:8090/static/config.csv would 404 in dev server, changed express config to app.use(/${staticPath}, express.static(path.join(__dirname, '../static')))

@countableSet countableSet changed the title add replication throttle config to rebalance options add replication throttle config to rebalance/add/remove/demote options Jan 22, 2025
@imans777

Copy link
Copy Markdown

update on this? would really appreciate having this!

@HerveRiviere

Copy link
Copy Markdown
Contributor

I'm also pretty interested by the feature, a merge will be great.
Thanks for the contribution !

In the meantime I try to merge it in our internal fork (https://github.com/criteo-forks/cruise-control-ui) to provide the feature to our users. Will post here if we see some bug or issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants