frontend: capture optional x-ambry-part-number in signed chunk ID metadata#3215
Merged
j-tyler merged 1 commit intolinkedin:masterfrom Mar 20, 2026
Merged
Conversation
…adata Add a new x-ambry-part-number header that clients may include on chunk upload requests. When present, PostBlobHandler captures the value into the signed chunk ID metadata map alongside the existing BLOB_SIZE, SESSION, and EXPIRATION_TIME fields. This allows downstream consumers to determine chunk ordering at upload time rather than waiting for the stitch request. The header is optional. When absent, no metadata key is added and existing behavior is completely unchanged. The Ambry server performs no validation on the value — it is stored as an opaque string. Also fix the HashMap initial capacity in setSignedIdMetadataAndBlobSize from 2 to 6, matching the actual number of entries (4 existing + 1 optional).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3215 +/- ##
============================================
+ Coverage 64.24% 69.81% +5.56%
- Complexity 10398 12821 +2423
============================================
Files 840 930 +90
Lines 71755 79129 +7374
Branches 8611 9468 +857
============================================
+ Hits 46099 55242 +9143
+ Misses 23004 20940 -2064
- Partials 2652 2947 +295 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SophieGuo410
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new x-ambry-part-number header that clients may include on chunk upload requests. When present, PostBlobHandler captures the value into the signed chunk ID metadata map alongside the existing BLOB_SIZE, SESSION, and EXPIRATION_TIME fields. This allows downstream consumers to determine chunk ordering at upload time rather than waiting for the stitch request.
The header is optional. When absent, no metadata key is added and existing behavior is completely unchanged. The Ambry server performs no validation on the value — it is stored as an opaque string.
Also fix the HashMap initial capacity in setSignedIdMetadataAndBlobSize from 2 to 6, matching the actual number of entries (4 existing + 1 optional).
Testing Done
Code already had good test coverage. Added new assertions for changed behavior.