vello_common: Correctly handle subpaths without initial MoveTo#1544
Merged
Conversation
See https://xi.zulipchat.com/#narrow/channel/197075-vello/topic/Left-Edge.20Culling.20Challenges/near/582038312. Co-authored-by: Dominik Honnef <dominik@honnef.co>
tomcur
force-pushed
the
push-tuvrtnyszsmp
branch
from
01918d8 to
16731c1
Compare
tomcur
force-pushed
the
push-tuvrtnyszsmp
branch
from
ad71e51 to
21965f0
Compare
dominikh
approved these changes
Mar 26, 2026
Contributor
dominikh
left a comment
dominikh
left a comment
There was a problem hiding this comment.
Technically we could track if we saw any MoveTo at all and debug_assert on that, but that's probably not worth the hassle.
tomcur
commented
Mar 29, 2026
Member
Author
tomcur
left a comment
tomcur
left a comment
There was a problem hiding this comment.
In SVG non-empty paths must start with a MoveTo. Kurbo was documenting that each subpath must start with a MoveTo. We now debug_assert that the first element of the path is a MoveTo, aligning with SVG.
I've opened linebender/kurbo#565 to align Kurbo with SVG's semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://xi.zulipchat.com/#narrow/channel/197075-vello/topic/Left-Edge.20Culling.20Challenges/near/582038312.