SVG paths: parsing NaN and Infinity#552
Open
nicoburns wants to merge 2 commits into
Open
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Member
|
I went to see if the svg spec had anything to say about this, but AFAICT the grammar doesn't even mention decimal points? Although the paragraph after the grammar clearly assumes that they're in there 😕 |
Contributor
Author
|
I've vendored a copy of kurbo's path parsing code into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows paths like
M0,0 L0,0 L90,0 LNaN,NaNto be parsed. This is useful for deserializing paths encoded in AnyRender serialized scenes. Otherwise deserializing panics.(one might argue that we ought to strip NaN's and Infinity's from scene's, but we may also want to specifically test for them, so I think it is best to at least have the capability to preserve them)