LCORE-4558: Fixed test mark

[tisnik]

Description

LCORE-4558: Fixed test mark

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library [pyproject.toml + uv.lock]
• Bump-up dependent library [requirements.*.txt for Konflux]
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-4558

Summary by CodeRabbit

• Tests
  • Updated authentication test data to match the expected format for parameter names. This is an internal test-only change; it does not alter authentication behavior or affect the product experience.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 5d3d2f31-799f-47f3-b410-de1fce904bc1

📥 Commits

Reviewing files that changed from the base of the PR and between 7b9d964 and fe82abf.

📒 Files selected for processing: 1

• tests/unit/authentication/test_rh_identity.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout: 30

• GitHub Check: E2E: library / ci / other
• GitHub Check: E2E: library / ci / default
• GitHub Check: E2E: library / ci / skills
• GitHub Check: E2E: server / ci / mcp
• GitHub Check: E2E: library / ci / shields
• GitHub Check: E2E: server / ci / other
• GitHub Check: E2E: server / ci / shields
• GitHub Check: E2E: library / ci / mcp
• GitHub Check: E2E: library / ci / rbac
• GitHub Check: E2E: server / ci / authorized
• GitHub Check: E2E: server / ci / skills
• GitHub Check: E2E: server / ci / rbac
• GitHub Check: E2E: server / ci / tls
• GitHub Check: E2E: library / ci / authorized
• GitHub Check: E2E: server / ci / default
• GitHub Check: Pylinter
• GitHub Check: bandit
• GitHub Check: integration_tests (3.14)
• GitHub Check: Pyright
• GitHub Check: unit_tests (3.13)
• GitHub Check: integration_tests (3.12)
• GitHub Check: unit_tests (3.14)
• GitHub Check: build-pr
• GitHub Check: unit_tests (3.12)
• GitHub Check: spectral
• GitHub Check: integration_tests (3.13)
• GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
• GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
• GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request

🔇 Additional comments: 1

tests/unit/authentication/test_rh_identity.py: 1

837-837: LGTM!

Walkthrough

The System identity field-validation test now declares its parameter names as a tuple. The test cases and assertions are unchanged.

Changes

System identity field validation

Layer / File(s)	Summary
Align test parameter shape tests/unit/authentication/test_rh_identity.py	The test parameter declaration now uses a two-element tuple instead of a comma-separated string.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to fe82a

This change only adjusts how the test parameter names are declared, without changing its cases or assertions. No material merge risk is apparent.

Pre-merge checks: 6 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Title check		The title refers to a test change, but the diff fixes test parameter names by changing a comma-separated string to a tuple. It does not fix a test mark.	Update the title to describe the actual change, for example: "LCORE-4558: Fix test field path parameters".

Passed checks: 6 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity		PASS. The pull request changes only the pytest parameter declaration in tests/unit/authentication/test_rh_identity.py (line 839). It does not add loops, API or database calls, list operations, parsi…
Security And Secret Handling		PASSED. The pull request changes only pytest parameter declaration syntax in tests/unit/authentication/test_rh_identity.py:838. It adds no secrets, authentication or authorization logic, endpoints, qu…

Full details: Performance And Algorithmic Complexity

Explanation

PASS. The pull request changes only the pytest parameter declaration in tests/unit/authentication/test_rh_identity.py (line 839). It does not add loops, API or database calls, list operations, parsing work, caches, buffers, or endpoint behavior. No meaningful performance regression is introduced.

Full details: Security And Secret Handling

Explanation

PASSED. The pull request changes only pytest parameter declaration syntax in tests/unit/authentication/test_rh_identity.py:838. It adds no secrets, authentication or authorization logic, endpoints, queries, command or path handling, API responses, logs, WebSocket messages, or Kubernetes/RH Secret resources.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

✨ Simplify code

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}