Skip to content

LCORE-4696: Added initial providers registry structure - #2908

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:LCORE-4696-providers-package-skeleton
Oct 15, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:LCORE-4696-providers-package-skeleton

Conversation

@asimurka

@asimurka asimurka commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

Add src/providers/ package skeleton for the inference provider registry: shared types (ProviderType, ModelType, ProviderId, empty PROVIDER_CLASSES) and empty packages for the seven backends under providers.inference/. No clients, discovery, or registry behavior yet.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: Cursor
  • Generated by: N/A

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Import providers / providers.inference.types and confirm no config load or network side effects.
  • Confirm ProviderType has the seven backends, ModelType is llm / embedding / rerank, and PROVIDER_CLASSES is empty.

Summary by CodeRabbit

  • Improvements
    • Added a structured format for inference catalog entries, including a model’s name, provider resource ID, type, and metadata.
    • Added shared definitions for supported provider names and model types.
  • Documentation
    • Added descriptions to inference provider packages and their unit test packages.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1aeaf7cb-8850-485e-9d66-56bf3ba562df
📥 Commits

Reviewing files that changed from the base of the PR and between 055e1a5 and 306fe52.

📒 Files selected for processing (14)
  • src/providers/__init__.py
  • src/providers/inference/__init__.py
  • src/providers/inference/azure/__init__.py
  • src/providers/inference/bedrock/__init__.py
  • src/providers/inference/catalog.py
  • src/providers/inference/openai/__init__.py
  • src/providers/inference/sentence_transformers/__init__.py
  • src/providers/inference/types.py
  • src/providers/inference/vertexai/__init__.py
  • src/providers/inference/vllm/__init__.py
  • src/providers/inference/watsonx/__init__.py
  • tests/unit/providers/__init__.py
  • tests/unit/providers/inference/__init__.py
  • tests/unit/providers/inference/test_catalog.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (26)
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: E2E: library / ci / shields
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: E2E: server / ci / shields
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: integration_tests (3.14)
  • GitHub Check: Pylinter
  • GitHub Check: build-pr
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered
📓 Path-based instructions (1)
Source excerpt: Package `__init__.py` files contain brief package descriptions

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • src/providers/inference/watsonx/__init__.py
  • src/providers/inference/azure/__init__.py
  • tests/unit/providers/inference/__init__.py
  • src/providers/inference/__init__.py
  • src/providers/inference/vllm/__init__.py
  • src/providers/inference/sentence_transformers/__init__.py
  • src/providers/__init__.py
  • src/providers/inference/vertexai/__init__.py
  • src/providers/inference/openai/__init__.py
  • tests/unit/providers/__init__.py
  • src/providers/inference/bedrock/__init__.py

Walkthrough

The change adds shared inference provider types and a Pydantic model for catalog entries. It also adds package docstrings for provider modules and a unit test for catalog model construction.

Changes

Inference provider catalog

Layer / File(s) Summary
Catalog model and provider types
src/providers/inference/types.py, src/providers/inference/catalog.py, src/providers/*/__init__.py, src/providers/inference/*/__init__.py, tests/unit/providers/*
Adds provider and model type aliases, a provider class mapping, and CatalogModel fields for the name, provider resource ID, model type, and metadata. Adds provider package docstrings and a test that checks the supplied catalog values.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 306fe

This foundation change introduces no concrete runtime, packaging, or workflow risk and is ready to merge after normal checks.

Pre-merge checks · Passed 7
Passed Passed checks (7 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding the initial providers registry structure.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 14 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity Passed PASS. The pull request adds package docstrings, type aliases, an empty provider mapping, a Pydantic model, and a construction test. It adds no loops, list operations, API or database calls, pagination…
Security And Secret Handling Passed PASSED. The pull request adds package docstrings, type aliases, an empty provider map, and a Pydantic catalog model. The changed source contains no hardcoded secrets, logging, API or WebSocket endpoin…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asimurka
asimurka force-pushed the LCORE-4696-providers-package-skeleton branch from c03e682 to 306fe52 Compare October 13, 2026 08:04
@asimurka
asimurka requested a review from jrobertboos October 13, 2026 11:36

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit 02dfb1d into lightspeed-core:main Oct 15, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants