Skip to content

LCORE-4566: Fixed unit test parametrization parameter - #2891

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4566-fixed-mark-parametrize-param
Oct 11, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4566-fixed-mark-parametrize-param

Conversation

@tisnik

@tisnik tisnik commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

LCORE-4566: Fixed unit test parametrization parameter

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4566

Summary by CodeRabbit

  • Tests
    • Updated the test parameter format; test cases and expected results are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c66c7512-be92-4e9f-ba00-97c734e43782

📥 Commits

Reviewing files that changed from the base of the PR and between 16d10ac and 2e2a1c6.


📒 Files selected for processing (1)
  • tests/unit/utils/test_responses.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📜 Recent review details
⏰ Context from checks skipped due to timeout. (25)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: spectral
  • GitHub Check: integration_tests (3.14)
  • GitHub Check: build-pr
  • GitHub Check: Pylinter
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: mypy
  • GitHub Check: bandit
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: shellcheck
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: ruff
  • GitHub Check: radon
  • GitHub Check: black
  • GitHub Check: check_dependencies
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: unit_tests (3.14)
  • GitHub Check: pydocstyle
  • GitHub Check: list_outdated_dependencies
  • GitHub Check: Pyright
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
  • GitHub Check: authorize / Check repository owner or member
  • GitHub Check: check

🔇 Additional comments (1)
tests/unit/utils/test_responses.py (1)

180-180: LGTM!



Walkthrough

The test_extract_text_basic_cases parametrization now uses a tuple for its parameter names. The test cases and expected results are unchanged.

Changes

Test parameter update

Layer / File(s) Summary
Update parameter names
tests/unit/utils/test_responses.py
The test now uses tuple-based parameter names instead of a comma-separated string. Cases and expected results are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Refactor

Suggested reviewers: asimurka

Merge Risk: ⚪ Minimal · up to 2e2a1

This test-only change preserves the existing cases and expectations, so no merge-blocking risk is evident.

Pre-merge checks | Passed 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and specifically describes the change to the unit test parametrization. It matches the main change in the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity Passed Passed. The pull request changes only the pytest parametrization argument-name syntax in tests/unit/utils/test_responses.py. It does not add loops, API or database calls, list operations, parsing, c…
Security And Secret Handling Passed PASSED. The pull request changes only pytest parametrization syntax in tests/unit/utils/test_responses.py. It adds no secrets, authentication or authorization logic, injection-prone behavior, API or…

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

✨ Simplify code
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit e0a9077 into lightspeed-core:main Oct 11, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant