Skip to content

LCORE-4620: Enforce D413 rule for tests - #2881

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4620-enforce-d413-rule-for-tests
Oct 9, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4620-enforce-d413-rule-for-tests

Conversation

@tisnik

@tisnik tisnik commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-4620: Enforce D413 rule for tests

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4620

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 103 files, which is 3 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c8fa55f6-f154-4560-bd19-ec7c70ae5d6d

📥 Commits

Reviewing files that changed from the base of the PR and between d95efb5 and e5d08a8.


📒 Files selected for processing (103)
  • tests/benchmarks/conftest.py
  • tests/benchmarks/data_generators.py
  • tests/benchmarks/db_benchmarks.py
  • tests/benchmarks/test_app_database.py
  • tests/benchmarks/test_app_database_comparison.py
  • tests/benchmarks/test_token_estimator.py
  • tests/e2e/features/environment.py
  • tests/e2e/features/steps/auth.py
  • tests/e2e/features/steps/common.py
  • tests/e2e/features/steps/common_http.py
  • tests/e2e/features/steps/health.py
  • tests/e2e/features/steps/okp_rag.py
  • tests/e2e/features/steps/place_holder.py
  • tests/e2e/features/steps/proxy.py
  • tests/e2e/features/steps/tls.py
  • tests/e2e/features/steps/token_counters.py
  • tests/e2e/mock_tls_inference_server/server.py
  • tests/e2e/proxy/interception_proxy.py
  • tests/e2e/proxy/tunnel_proxy.py
  • tests/e2e/utils/ogx_config_utils.py
  • tests/e2e/utils/prow_utils.py
  • tests/e2e/utils/utils.py
  • tests/integration/conftest.py
  • tests/integration/container_lifecycle/test_container_lifecycle.py
  • tests/integration/endpoints/_compaction_helpers.py
  • tests/integration/endpoints/test_authorized_endpoint.py
  • tests/integration/endpoints/test_compaction_a2a.py
  • tests/integration/endpoints/test_compaction_query.py
  • tests/integration/endpoints/test_compaction_responses.py
  • tests/integration/endpoints/test_compaction_streaming_query.py
  • tests/integration/endpoints/test_config_integration.py
  • tests/integration/endpoints/test_conversations_v1_integration.py
  • tests/integration/endpoints/test_conversations_v2_integration.py
  • tests/integration/endpoints/test_granite_guardian_integration.py
  • tests/integration/endpoints/test_health_integration.py
  • tests/integration/endpoints/test_info_integration.py
  • tests/integration/endpoints/test_model_list.py
  • tests/integration/endpoints/test_query_byok_integration.py
  • tests/integration/endpoints/test_query_integration.py
  • tests/integration/endpoints/test_responses_integration.py
  • tests/integration/endpoints/test_root_endpoint.py
  • tests/integration/endpoints/test_saved_prompts_integration.py
  • tests/integration/endpoints/test_skills_integration.py
  • tests/integration/endpoints/test_streaming_query_byok_integration.py
  • tests/integration/endpoints/test_streaming_query_integration.py
  • tests/integration/endpoints/test_tools_integration.py
  • tests/integration/test_configuration.py
  • tests/integration/test_feedback_otel_trace.py
  • tests/integration/test_openapi_json.py
  • tests/integration/test_otel_trace_propagation.py
  • tests/integration/test_rh_identity_integration.py
  • tests/integration/test_version.py
  • tests/unit/app/endpoints/conftest.py
  • tests/unit/app/endpoints/responses_otel_helpers.py
  • tests/unit/app/endpoints/test_conversations.py
  • tests/unit/app/endpoints/test_conversations_v2.py
  • tests/unit/app/endpoints/test_query.py
  • tests/unit/app/endpoints/test_rags.py
  • tests/unit/app/endpoints/test_rlsapi_v1.py
  • tests/unit/app/endpoints/test_saved_prompts.py
  • tests/unit/app/endpoints/test_vector_stores.py
  • tests/unit/app/test_database.py
  • tests/unit/app/test_routers.py
  • tests/unit/authentication/test_api_key_token.py
  • tests/unit/authentication/test_jwk_token.py
  • tests/unit/authentication/test_k8s.py
  • tests/unit/authentication/test_rh_identity.py
  • tests/unit/authorization/test_middleware.py
  • tests/unit/authorization/test_resolvers.py
  • tests/unit/cache/test_cache_factory.py
  • tests/unit/cache/test_noop_cache.py
  • tests/unit/cache/test_postgres_cache.py
  • tests/unit/cache/test_sqlite_cache.py
  • tests/unit/conftest.py
  • tests/unit/models/config/test_authentication_configuration.py
  • tests/unit/models/config/test_byok_rag.py
  • tests/unit/models/config/test_conversation_history.py
  • tests/unit/models/config/test_customization.py
  • tests/unit/models/config/test_database_configuration.py
  • tests/unit/models/config/test_dump_configuration.py
  • tests/unit/models/config/test_jwt_role_rule.py
  • tests/unit/models/config/test_observability_configuration.py
  • tests/unit/models/config/test_postgresql_database_configuration.py
  • tests/unit/models/config/test_rlsapi_v1_configuration.py
  • tests/unit/models/config/test_splunk_configuration.py
  • tests/unit/models/config/test_tls_configuration.py
  • tests/unit/models/config/test_user_data_collection.py
  • tests/unit/models/config/test_vector_store.py
  • tests/unit/models/database/test_saved_prompts.py
  • tests/unit/models/rlsapi/test_requests.py
  • tests/unit/models/rlsapi/test_responses.py
  • tests/unit/models/test_saved_prompts_config.py
  • tests/unit/observability/conftest.py
  • tests/unit/observability/test_splunk.py
  • tests/unit/pydantic_ai_lightspeed/capabilities/redaction/test_capability.py
  • tests/unit/pydantic_ai_lightspeed/ogx/test_transport.py
  • tests/unit/quota/test_cluster_quota_limiter.py
  • tests/unit/telemetry/conftest.py
  • tests/unit/utils/auth_helpers.py
  • tests/unit/utils/test_conversations.py
  • tests/unit/utils/test_ogx_version.py
  • tests/unit/utils/test_responses.py
  • tests/unit/utils/test_saved_prompts.py

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit e24f81f into lightspeed-core:main Oct 9, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant