Skip to content

LCORE-4549: Refactored first arg to test parametrization - #2859

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4549-refactored-first-arg-to-test-parametrization
Oct 7, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4549-refactored-first-arg-to-test-parametrization

Conversation

@tisnik

@tisnik tisnik commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

LCORE-4549: Refactored first arg to test parametrization

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4549

Summary by CodeRabbit

  • Tests
    • Updated authentication test parameter definitions to use tuple-based argument names.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d5328783-a3e6-4f40-8c60-5e4814467535
📥 Commits

Reviewing files that changed from the base of the PR and between bf89798 and 0e0784c.

📒 Files selected for processing (1)
  • tests/unit/authentication/test_k8s.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (25)
  • GitHub Check: E2E: server / ci / shields
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: library / ci / shields
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: Pylinter
  • GitHub Check: build-pr
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
🔇 Additional comments (1)
tests/unit/authentication/test_k8s.py (1)

1085-1091: LGTM!


Walkthrough

The API error handling test now provides its unchanged parameter names as a tuple instead of a comma-delimited string.

Changes

Authentication test

Layer / File(s) Summary
Test parameter declaration
tests/unit/authentication/test_k8s.py
The test now declares its parameter names as a tuple. The names are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 0e078

No material behavior change or merge-blocking risk is indicated by this test refactor.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the test parametrization refactor, which matches the change to provide argument names as a tuple.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PASS. The only change replaces the comma-delimited pytest.mark.parametrize argument names with an equivalent tuple in a unit test. It adds no loop, API call, parsing work, cache, or List operation, …
Security And Secret Handling ✅ Passed The change only converts the pytest parameter-name string to a tuple in tests/unit/authentication/test_k8s.py (lines 1084–1091). It adds no secret, endpoint, request handling, logging, or Kubernetes…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit b1aa7b1 into lightspeed-core:main Oct 7, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant