Skip to content

LCORE-4548: Refactor pytest mark - #2855

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4548-refactor-tuple
Oct 6, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-4548-refactor-tuple

Conversation

@tisnik

@tisnik tisnik commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

LCORE-4548: Refactor pytest mark

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4548

Summary by CodeRabbit

  • Tests
    • Updated the file-based API test to use a tuple for its parameter names. Expected routes and response codes are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 339bd028-6269-417f-a256-69c9117bdc25
📥 Commits

Reviewing files that changed from the base of the PR and between acaa149 and ebc9419.

📒 Files selected for processing (1)
  • tests/integration/test_openapi_json.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (25)
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: library / ci / shields
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: E2E: server / ci / shields
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: build-pr
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: Pylinter
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
🔇 Additional comments (1)
tests/integration/test_openapi_json.py (1)

328-328: LGTM!


Walkthrough

The file-based path-and-response test changes its parameter names from a comma-separated string to a tuple. The parameter values and expected response codes remain unchanged.

Changes

OpenAPI integration test

Layer / File(s) Summary
Update test parameter names
tests/integration/test_openapi_json.py
The test uses a tuple for its parameter names. The parameter values and expected response codes remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Suggested reviewers: asimurka

Merge Risk: ⚪ Minimal · up to ebc94

The test parameterization change preserves the existing mapping and is supported by the project's pytest version requirement. No actionable merge risk was identified.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the change as a pytest mark refactor. It is related, but it does not specify the parametrization argument change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PASSED. The only change is in tests/integration/test_openapi_json.py: the pytest parameter names change from a comma-separated string to a tuple. This introduces no algorithmic work, API calls, unboun…
Security And Secret Handling ✅ Passed PASSED. The only change is in tests/integration/test_openapi_json.py: the pytest parameter names change from a comma-separated string to a tuple. The API paths, response codes, and application behavio…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit bf89798 into lightspeed-core:main Oct 6, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant