Skip to content

LCORE-2664: finalize spike: remove PoC artifacts, stamp JIRA keys - #2320

Merged
tisnik merged 2 commits into
lightspeed-core:mainfrom
max-svistunov:lcore-2664-finalize-spike
Aug 3, 2026
Merged

tisnik merged 2 commits into
lightspeed-core:mainfrom
max-svistunov:lcore-2664-finalize-spike

Conversation

@max-svistunov

Copy link
Copy Markdown
Contributor

Title: LCORE-2664: finalize spike: remove PoC artifacts, stamp JIRA keys

Description

Post-merge finalization of the LCORE-2664 spike (PR #2178). Two things
the spike workflow schedules around merge time that #2178 landed without:

  1. Remove PoC artifacts. LCORE-2664: Spike — BYOK auto-import from Confluence #2178's "Pre-merge cleanup" section planned
    deletion of docs/design/byok-confluence-import/poc/ and
    poc-results/ before merge, keeping only the spike and spec docs
    (per docs/contributing/howto-organize-poc-output.md); the merge
    happened with both directories still present. This completes that
    already-approved step — deletions only. The artifacts remain in the
    LCORE-2664: Spike — BYOK auto-import from Confluence #2178 branch history, and the spike doc's "PoC results" section
    preserves the findings.

  2. Replace LCORE-???? placeholders with filed ticket keys. The
    proposed JIRAs are now filed under LCORE-788: Epic LCORE-3374 with
    children LCORE-3375..LCORE-3380, plus incidental LCORE-3381. All
    heading/key stamps and in-body Blocks / Blocked-by cross-references
    in the spike doc now carry the real keys, matching the issue links
    created in Jira. The Epic's key is recorded as a
    <!-- key: LCORE-3374 --> comment under its heading so future
    re-parses of the doc re-sync tickets as updates instead of filing
    duplicates.

Type of change

  • Documentation Update

Tools used to create PR

  • Assisted-by: Claude Opus 4.8
  • Generated by: Claude Opus 4.8

Related Tickets & Documents

  • Related Issue # LCORE-788, LCORE-3374
  • Closes # LCORE-2664 (already closed; this PR completes its finalization steps)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

Docs-only change; no runtime surface.

  • Verify only deletions + one doc touched:
    git diff --stat upstream/main shows 9 deleted files under
    docs/design/byok-confluence-import/{poc,poc-results}/ and edits to
    byok-confluence-import-spike.md only.
  • Verify no orphan placeholders remain:
    grep -rn 'LCORE-????' docs/design/byok-confluence-import/ returns
    nothing (verified: 0 matches in spike and spec doc).
  • Verify the JIRA section still parses and detects the filed keys:
    sh dev-tools/file-jiras.sh --spike-doc docs/design/byok-confluence-import/byok-confluence-import-spike.md --feature-ticket LCORE-788 --parse-only parses 1 Epic + 6 JIRAs +
    1 incidental with keys LCORE-3374..LCORE-3381 (verified: all eight
    detected, no lint warnings).

The spike PR (lightspeed-core#2178) planned removal of the PoC code and validation
evidence before merge (see its Pre-merge cleanup section and
docs/contributing/howto-organize-poc-output.md), keeping only the spike
and spec docs; the merge landed with both directories still present.

Remove docs/design/byok-confluence-import/poc/ and poc-results/. The
artifacts remain reachable in the PR lightspeed-core#2178 branch history; the spike
doc's PoC results section preserves the salient findings and evidence
summary.
The proposed JIRAs are now filed: Epic LCORE-3374 with children
LCORE-3375 (e2e feature files kickoff), LCORE-3376 (step definitions),
LCORE-3377 (Confluence fetch stage), LCORE-3378 (importer command and
packaging), LCORE-3379 (scheduled-refresh references and admin guide),
LCORE-3380 (lightspeed-stack docs), plus incidental LCORE-3381 filed
standalone under a Related link to LCORE-788.

Replace every LCORE-???? placeholder in the spike doc with the real
key: heading and key-comment stamps for all seven tickets plus the
incidental, and the in-body Blocks / Blocked-by / covered-by
cross-references, which now match the issue links created in Jira.

The Epic records its key as a <!-- key: LCORE-3374 --> comment under
the ### Epic: heading: the parser has no key slot in Epic headings,
and the filing script's key detection accepts a key comment anywhere
in the parsed file while description extraction strips it, so
re-parsing the doc now regenerates ticket files that re-sync as
updates instead of filing duplicates.
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@max-svistunov, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 026d6bc5-380a-42f4-9f0f-cf1b18c0e09c

📥 Commits

Reviewing files that changed from the base of the PR and between 40aa374 and 5253cb0.

📒 Files selected for processing (10)
  • docs/design/byok-confluence-import/byok-confluence-import-spike.md
  • docs/design/byok-confluence-import/poc-results/README.md
  • docs/design/byok-confluence-import/poc-results/conversion-sample.md
  • docs/design/byok-confluence-import/poc-results/crawl-runs.txt
  • docs/design/byok-confluence-import/poc-results/retrieval-evidence.txt
  • docs/design/byok-confluence-import/poc/README.md
  • docs/design/byok-confluence-import/poc/confluence_fetch.py
  • docs/design/byok-confluence-import/poc/confluence_processor.py
  • docs/design/byok-confluence-import/poc/confluence_test_page.py
  • docs/design/byok-confluence-import/poc/query_workaround.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit e6a4116 into lightspeed-core:main Aug 3, 2026
20 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants