Repository navigation
LCORE-2664: finalize spike: remove PoC artifacts, stamp JIRA keys - #2320
Conversation
The spike PR (lightspeed-core#2178) planned removal of the PoC code and validation evidence before merge (see its Pre-merge cleanup section and docs/contributing/howto-organize-poc-output.md), keeping only the spike and spec docs; the merge landed with both directories still present. Remove docs/design/byok-confluence-import/poc/ and poc-results/. The artifacts remain reachable in the PR lightspeed-core#2178 branch history; the spike doc's PoC results section preserves the salient findings and evidence summary.
The proposed JIRAs are now filed: Epic LCORE-3374 with children LCORE-3375 (e2e feature files kickoff), LCORE-3376 (step definitions), LCORE-3377 (Confluence fetch stage), LCORE-3378 (importer command and packaging), LCORE-3379 (scheduled-refresh references and admin guide), LCORE-3380 (lightspeed-stack docs), plus incidental LCORE-3381 filed standalone under a Related link to LCORE-788. Replace every LCORE-???? placeholder in the spike doc with the real key: heading and key-comment stamps for all seven tickets plus the incidental, and the in-body Blocks / Blocked-by / covered-by cross-references, which now match the issue links created in Jira. The Epic records its key as a <!-- key: LCORE-3374 --> comment under the ### Epic: heading: the parser has no key slot in Epic headings, and the filing script's key detection accepts a key comment anywhere in the parsed file while description extraction strips it, so re-parsing the doc now regenerates ticket files that re-sync as updates instead of filing duplicates.
|
Warning Review limit reached
Next review available in: 12 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Title: LCORE-2664: finalize spike: remove PoC artifacts, stamp JIRA keys
Description
Post-merge finalization of the LCORE-2664 spike (PR #2178). Two things
the spike workflow schedules around merge time that #2178 landed without:
Remove PoC artifacts. LCORE-2664: Spike — BYOK auto-import from Confluence #2178's "Pre-merge cleanup" section planned
deletion of
docs/design/byok-confluence-import/poc/andpoc-results/before merge, keeping only the spike and spec docs(per
docs/contributing/howto-organize-poc-output.md); the mergehappened with both directories still present. This completes that
already-approved step — deletions only. The artifacts remain in the
LCORE-2664: Spike — BYOK auto-import from Confluence #2178 branch history, and the spike doc's "PoC results" section
preserves the findings.
Replace
LCORE-????placeholders with filed ticket keys. Theproposed JIRAs are now filed under LCORE-788: Epic LCORE-3374 with
children LCORE-3375..LCORE-3380, plus incidental LCORE-3381. All
heading/key stamps and in-body Blocks / Blocked-by cross-references
in the spike doc now carry the real keys, matching the issue links
created in Jira. The Epic's key is recorded as a
<!-- key: LCORE-3374 -->comment under its heading so futurere-parses of the doc re-sync tickets as updates instead of filing
duplicates.
Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
Docs-only change; no runtime surface.
git diff --stat upstream/mainshows 9 deleted files underdocs/design/byok-confluence-import/{poc,poc-results}/and edits tobyok-confluence-import-spike.mdonly.grep -rn 'LCORE-????' docs/design/byok-confluence-import/returnsnothing (verified: 0 matches in spike and spec doc).
sh dev-tools/file-jiras.sh --spike-doc docs/design/byok-confluence-import/byok-confluence-import-spike.md --feature-ticket LCORE-788 --parse-onlyparses 1 Epic + 6 JIRAs +1 incidental with keys LCORE-3374..LCORE-3381 (verified: all eight
detected, no lint warnings).