fix WPT failures: nodeName, PI validation, willValidate, maxLength#1621
Merged
karlseguin merged 1 commit intolightpanda-io:mainfrom Feb 21, 2026
Merged
fix WPT failures: nodeName, PI validation, willValidate, maxLength#1621karlseguin merged 1 commit intolightpanda-io:mainfrom
karlseguin merged 1 commit intolightpanda-io:mainfrom
Conversation
…maxLength - uppercase entire qualified name in tagName (including prefix) - validate PI data for "?>" and use proper XML Name production with Unicode - implement willValidate on HTMLInputElement - throw IndexSizeError DOMException for negative maxLength assignment flips: Node-nodeName, Document-createProcessingInstruction, button, maxlength, input-willvalidate (+6 subtests)
egrs
force-pushed
the
wpt-fixes-batch-2
branch
from
19ea489 to
a90bcde
Compare
egrs
changed the title
egrs
changed the title
egrs
force-pushed
the
wpt-fixes-batch-2
branch
from
18151c3 to
a90bcde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x:b→X:B)?>, add proper XML Name production validator with full Unicode support (NameStartChar/NameChar per W3C spec)IndexSizeErrorDOMException instead of custom error for negative valuesWPT results
dom/nodes/Node-nodeName.htmldom/nodes/Document-createProcessingInstruction.htmlhtml/semantics/forms/the-input-element/button.htmlhtml/semantics/forms/the-input-element/maxlength.htmlhtml/semantics/forms/the-input-element/input-willvalidate.html5 file flips, +6 subtests.
Test plan
make test— 280/280 pass