Keep bundled PostgreSQL stable during upgrades - #154
Merged
Conversation
Create bundled PostgreSQL only during chart installation. Helm upgrades no longer recreate its hook resources. Document the manual path for postgresql.* changes until chart 3.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bundled PostgreSQL now runs only as a pre-install hook. The hook weight remains
-1.The chart version is 2.14.0.
Why
The pre-upgrade hook recreated the PostgreSQL StatefulSet during every chart upgrade. This interrupted the database and removed every backend pod from the Service endpoints.
Operator impact
Helm upgrades no longer modify the bundled database. Apply changes to
postgresql.*values manually. The full management migration is planned for the 3.0.0 chart major.Verification
helm lint --strict charts/lightdash.pre-installhook.-1.Security triage: LOW (values annotation + docs only), scan waived by orchestrator.
Linear: SPK-1114