Remove model_new directory from annuallife library#105
Merged
Conversation
Drop the intermediate model_new snapshot from the annuallife library and update the library docs to no longer reference it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the entire
model_newdirectory from the annuallife library, which contained an incomplete/experimental modelx-based implementation of the annuallife model.Summary
The
model_newdirectory was an alternative implementation approach that is no longer being used or maintained. Removing it cleans up the codebase and eliminates dead code.Changes Made
model_newdirectory structure including:BaseProj,Projection,Economic,Assumptions,PolicyAttrs,Input,CommTable,PV,UtilitiesProductID,RateBasisID,SexID_system.json, binary data filesmakedocs/source/libraries/annuallife/index.rstto remove references to the model_new implementationRationale
The
model_newdirectory represented an experimental refactoring that was superseded by the current implementation. Removing it reduces maintenance burden and eliminates confusion about which implementation is the canonical one.https://claude.ai/code/session_01LE1EybSUgdycp7VQggcPym