fix(cursor): route native fallbacks through code mode - #1896
fix(cursor): route native fallbacks through code mode#1896luvyoun0224-beep wants to merge 2 commits into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
Summary
functionsnamespace now flattens ordinary client functions and its nested freeformcustom execinto top-level internal tools.shell_command/exec_commandfallback instructions with the real code-mode contract: top-levelexec, then nestedtools.exec_command(...)ortools.apply_patch(...), withtext(...)output.additional_toolsshape, filesystem, shell, fetch, MCP-resource, mutation, and live-transport propagation paths.This follows #1844. That change fixed system guidance, but two gaps remained: Codex 0.147 groups
custom execunder the reservedfunctionsnamespace, which the parser dropped, and Cursor-native rejection responses still directed models to top-level tools that do not exist in code mode.Verification
tests/cursor-*.test.tsfiles: 602 passbun run typecheckbun run privacy:scangit diff --checkGet-Content package.jsonand read version2.22.0; the following model continuation hit the account's Cursor resource limit, so the probe did not receive its requested final formatted line.bun testwas attempted on Windows; it stopped making progress during unrelated integration tests and was interrupted after more than 90 seconds without output.Checklist
AI assistance was used for implementation and test preparation; the resulting diff and verification output were reviewed locally.
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.