fix(antigravity): drop synthetic x-goog-api-client header on onboarding - #1889
fix(antigravity): drop synthetic x-goog-api-client header on onboarding#1889dbc-hbin wants to merge 1 commit into
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughWalkthroughAntigravity OAuth onboarding now uses ChangesAntigravity OAuth identity
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change removes an unused onboarding header and aligns the IDE version metadata; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
6bcaa95 to
eb3132e
Compare
- Remove synthetic x-goog-api-client header from Antigravity onboardUser requests. - Decompilation of Antigravity IDE 2.5.5 (language_server_macos_arm) confirmed x-goog-api-client is never sent on the wire (0 ADRP hits across all SetHTTPHeaders variants). - Pass ANTIGRAVITY_IDE_VERSION for metadata.ide_version instead of the full User-Agent string. - Remove obsolete ANTIGRAVITY_GOOG_API_CLIENT_UA export and test.
eb3132e to
ea64418
Compare
Summary
Remove synthetic
x-goog-api-clientheader from AntigravityonboardUserrequests and passANTIGRAVITY_IDE_VERSIONformetadata.ide_version.Context & Evidence
Following discussion in #1836:
language_server_macos_arm126MB Go1.26.5) confirms thatx-goog-api-clientis never sent on the wire.SetHTTPHeadersvariants (IDE,CLI,Hub,Standalone,Stubby).0x24ea019is part of agenerationConfig.x-goog-api-clientdescriptor, not a header.metadata.ide_versioninonboardUseris aligned toANTIGRAVITY_IDE_VERSION(2.5.5), separating it from theUser-Agentheader.ANTIGRAVITY_GOOG_API_CLIENT_UAexport and associated test.Verification
bun test tests/client-fingerprint.test.ts tests/google-antigravity-oauth.test.ts tests/google-antigravity-wire.test.ts(71 passed, 0 failed)bun run typecheck(passed with 0 errors)Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.