-
-
Notifications
You must be signed in to change notification settings - Fork 340
Fix: show check highlight for spectators by passing interactiveBoardParams in TvScreen #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: show check highlight for spectators by passing interactiveBoardParams in TvScreen #2208
Conversation
…arams in TvScreen
|
@veloce |
|
@Sanket-Kurle Veloce is currently on holiday, he will review this PR in due time. |
|
okay 👍 |
|
@HaonRekcef have you seen these changes |
|
Yes looks good to me thanks! Did you test them in a real game as a spectator? |
|
not in real game |
|
You can write me on lichess: https://lichess.org/@/nfchess13 |
|
I see the changes. I don't understand the Spectator Check Demo screenshot though. It does not come from the app, it is not really useful then. |
|
I don't really like passing |
I updated tv_screen.dart to properly configure the chessboard in spectator mode.

Added interactiveBoardParams with PlayerSide.none
this is solution for issue #2128