build: retire legacy ci in favor of container build#142
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR retires the legacy CI/CD workflow that used SSH-based deployment to a specific host (rubik) and systemd service files, replacing it with a modern container-based build and deployment approach using GitHub Container Registry.
Changes:
- Removed systemd service and socket configuration files previously used for direct host deployment
- Deleted the legacy CI workflow that built and deployed via SSH
- Refactored the Dockerfile to use cargo-chef multi-stage build pattern for better build caching
- Enhanced the Docker workflow to support PR builds, use GitHub Actions cache, and Docker Buildx
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lila-push.socket | Removed systemd socket configuration for legacy deployment |
| lila-push.service | Removed systemd service configuration for legacy deployment |
| .github/workflows/ci.yml | Removed entire legacy CI workflow with SSH-based deployment |
| Dockerfile | Refactored to use cargo-chef pattern with chef/planner/builder stages |
| .github/workflows/docker.yml | Added PR trigger, updated to checkout@v6, added Buildx setup and GHA caching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.