simplify buffer resizing

[JasonLG1979]

This way is less verbose, much more simple and less brittle.

[JasonLG1979]

@roderickvd I wasn't happy with the match and trying to be "clever" and doing different things when trying to lower or raise the capacity seemed brittle. As rarely as the buffer will ever be resized. (which is currently once) "clever" doesn't save us anything.

[roderickvd]

Well, amen to that, I didn't like that clippy suggestion either. In this case couldn't we just do self.period_buffer = Vec::with_capacity(bytes_per_period) to simplify the three calls even further?

[JasonLG1979]

Well, amen to that, I didn't like that clippy suggestion either. In this case couldn't we just do self.period_buffer = Vec::with_capacity(bytes_per_period) to simplify the three calls even further?

Done.

[ashthespy]

From the discussions previously over in #811, this undoes those "optimisations" correct? As it is deemed these micro optimisation are not really worth the extra cruft?

[JasonLG1979]

From the discussions previously over in #811, this undoes those "optimisations" correct? As it is deemed these micro optimisation are not really worth the extra cruft?

Basically yes. This does 99.9% of what I was after, not reallocating if the buffer size doesn't change.

[roderickvd]

Alright then, let's go for it.