refactor(edit): let git handle the edit instead of the custom impleme…#96
Open
Teamop wants to merge 1 commit into
Open
refactor(edit): let git handle the edit instead of the custom impleme…#96Teamop wants to merge 1 commit into
Teamop wants to merge 1 commit into
Conversation
Member
|
@Teamop no problems at all. As long as we have a similar user experience as now. Would git allow us to edit the message? |
Author
|
@leonardoanalista yes, I used this behavior in my project for 3 years, I didn't meet any errors. |
Member
|
I am happy to go ahead with this @Teamop. Let's recap the benefits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntation
Thoughts about this change:
editorby default opens thenotepadorvim, but there's scenarios:vim,notepadso I think it's best to let
gitto handle all of the cases instead of the custom implemetation.