Skip to content

refactor(edit): let git handle the edit instead of the custom impleme…#96

Open
Teamop wants to merge 1 commit into
leoforfree:masterfrom
Teamop:improve-edit
Open

refactor(edit): let git handle the edit instead of the custom impleme…#96
Teamop wants to merge 1 commit into
leoforfree:masterfrom
Teamop:improve-edit

Conversation

@Teamop

@Teamop Teamop commented Aug 19, 2019

Copy link
Copy Markdown

…ntation
Thoughts about this change:
editor by default opens the notepad or vim, but there's scenarios:

  1. a linux machine without vim,
  2. the message format is not displayed correctly in notepad

so I think it's best to let git to handle all of the cases instead of the custom implemetation.

@leonardoanalista

Copy link
Copy Markdown
Member

@Teamop no problems at all. As long as we have a similar user experience as now.

Would git allow us to edit the message?
Would we still be able to get the commit done directly when we don't want to edit the message?

@Teamop

Teamop commented Jul 14, 2022

Copy link
Copy Markdown
Author

@leonardoanalista yes, I used this behavior in my project for 3 years, I didn't meet any errors.

@leonardoanalista

Copy link
Copy Markdown
Member

I am happy to go ahead with this @Teamop. Let's recap the benefits:

  • Let GIT handle the commit message so it works with machines without vim or with another default Git editor
  • remove some dependencies: editor, temp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants